Import better rejection message #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
requested changes
Apr 30, 2024
| log.error("Problems concerning Import `{}`:\n{}", name, errors); | ||
| throw new IllegalArgumentException(String.format("Headers[%s.%s] do not match Table[%s]. More info in logs.", getTable(), getName(), table.getId())); | ||
| log.error("Problems concerning Import `{}`:\n - {}", name, errors); | ||
| throw new BadRequestException(String.format("Import[%s.%s] does not match Table[%s]: %s", getTable(), getName(), table.getId(), errors)); |
There was a problem hiding this comment.
Ich würde hier keine webexception werfen sondern auf Resource- oder Processor-Ebene abfangen und dort werfen
There was a problem hiding this comment.
ImportJob createOrUpdate wirft auch kontext-abhägige WebExceptions. Ich kann das assertMatch da rein schieben, dann ist das zumindest so gekapselt
backend/src/main/java/com/bakdata/conquery/resources/admin/rest/AdminDatasetResource.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/resources/admin/rest/AdminDatasetResource.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/resources/admin/rest/AdminDatasetResource.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/resources/admin/rest/AdminDatasetResource.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/resources/admin/rest/AdminDatasetResource.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/preproc/PreprocessedHeader.java
Outdated
Show resolved
Hide resolved
delete-merged-branch
bot
deleted the
feature/import-better-rejection-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hier wurden vor allem die Nachrichten für falsche Spalten nicht ausgegeben, wodurch das ganze schwer nachzuvollziehen war für das Datenteam.