Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework version info format #3381

Merged
merged 9 commits into from
May 14, 2024
Merged

Rework version info format #3381

merged 9 commits into from
May 14, 2024

Conversation

thoniTUB
Copy link
Collaborator

@thoniTUB thoniTUB commented Apr 8, 2024 •
edited
Loading

Uniform version objects for backend and formbackends:

"versions": [
  { "name": "Backend", "version": "2.0.0-2024KW09-27-gc2a69844", "buildTime": "2007-08-31T16:47" },
  { "name": "Jupyend", "version": "2.0.0-2024KW09-27-gc2a69844" },
  ...
]

@thoniTUB
wip update version info format
8b7a72c 
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
@thoniTUB thoniTUB requested a review from awildturtok April 8, 2024 20:18
thoniTUB
thoniTUB commented Apr 8, 2024
View reviewed changes
backend/src/main/java/com/bakdata/conquery/apiv1/frontend/VersionContainer.java
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kadrian this is the new format for the version info version and buildTime are nullable/optional

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the open-api spec:
https://editor.swagger.io/?url=https://raw.githubusercontent.com/ingef/conquery/bc03b16ff9d32c556a158f923f65914a8b443ce6/openapi.yaml

@thoniTUB thoniTUB marked this pull request as draft April 8, 2024 20:22
thoniTUB added 2 commits April 9, 2024 13:48
@thoniTUB
passthrough buildTime from form backends
878062c 
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
@thoniTUB
update openapi specs
bc03b16 
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
@thoniTUB thoniTUB added backend frontend http api change causes a change in a http api labels Apr 9, 2024
@thoniTUB thoniTUB self-assigned this Apr 9, 2024
@thoniTUB thoniTUB marked this pull request as ready for review April 29, 2024 08:48
@Kadrian Kadrian changed the title version info format rework Rework version info format May 13, 2024
@thoniTUB thoniTUB enabled auto-merge May 13, 2024 11:43
@Kadrian Kadrian disabled auto-merge May 14, 2024 08:58
@Kadrian Kadrian enabled auto-merge May 14, 2024 08:58
@Kadrian Kadrian merged commit cbdf7bb into develop May 14, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/version-propagation-rework branch May 14, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kadrian Kadrian Kadrian approved these changes

@awildturtok awildturtok awildturtok approved these changes

Assignees

@Kadrian Kadrian

@thoniTUB thoniTUB

Labels
backend frontend http api change causes a change in a http api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thoniTUB @Kadrian @awildturtok