don't use UUID in worker storage. #3360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If possible, use hostname for workerName
…rkers, to handle NonPersistentStorage case for non-unique storage names
thoniTUB
reviewed
Apr 2, 2024
Comment on lines
+26
to
+36
|
|
||
| Wait.builder() | ||
| .stepTime(Duration.ofMillis(5)) | ||
| .total(Duration.ofSeconds(10)) | ||
| .build() | ||
| .until(()->getShardNode(context) != null); | ||
|
|
||
| .until(() -> getShardNode(context) != null); | ||
|
|
||
| ShardNodeInformation node = getShardNode(context); | ||
|
|
||
| if(node == null) { | ||
| throw new IllegalStateException("Could not find the slave "+context.getRemoteAddress()+" to register worker "+info.getId()); | ||
| throw new IllegalStateException("Could not find the shard %s to register worker %s".formatted(context.getRemoteAddress(), info.getId())); |
There was a problem hiding this comment.
Ouh wie hat das vorher nur funktioniert?
| int entityBucketSize, | ||
| ObjectMapper persistenceMapper, | ||
| ObjectMapper communicationMapper, int secondaryIdSubPlanLimit) { | ||
| public static Worker newWorker(@NonNull Dataset dataset, @NonNull ThreadPoolDefinition queryThreadPoolDefinition, @NonNull ExecutorService jobsExecutorService, @NonNull StoreFactory config, @NonNull String directory, @NonNull Validator validator, boolean failOnError, int entityBucketSize, ObjectMapper persistenceMapper, ObjectMapper communicationMapper, int secondaryIdSubPlanLimit) { |
There was a problem hiding this comment.
Gerne wieder zu einer Liste machen
Comment on lines
+108
to
+109
| //The UUID suffix is necessary for shards running on the same hostname. | ||
| return InetAddress.getLocalHost().getHostName() + "#" + uuid; |
There was a problem hiding this comment.
War die Directory anstatt der UUID nicht ausreichend, die sollte doch den Shard Namen inne haben und somit pro dataset eindeutig sein
| dataset2Worker.put(worker.getStorage().getDataset().getId(), worker); | ||
| final DatasetId datasetId = worker.getStorage().getDataset().getId(); | ||
| if (workers.put(datasetId, worker) != null) { | ||
| log.warn("Already have a worker for dataset {}: {}", datasetId, worker); |
There was a problem hiding this comment.
Illegalstate? Oder informieren, dass die referenz überschireben wurde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If possible, use hostname for workerName