Bump io.dropwizard:dropwizard-dependencies from 2.1.1 to 4.0.6 #3284

dependabot · 2024-01-31T04:23:25Z

Bumps io.dropwizard:dropwizard-dependencies from 2.1.1 to 4.0.6.

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

awildturtok · 2024-01-31T11:54:40Z

https://stackoverflow.com/questions/30629282/dropwizard-jersey-not-inside-a-request-scope-when-creating-custom-annotati

dependabot · 2024-03-07T04:47:28Z

A newer version of io.dropwizard:dropwizard-dependencies exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Bumps io.dropwizard:dropwizard-dependencies from 2.1.1 to 4.0.6. --- updated-dependencies: - dependency-name: io.dropwizard:dropwizard-dependencies dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…hFilter needs to be fixed next

thoniTUB

Bin noch nicht durch, gh lässt mich jetzt jeden diff einzeln laden 😨

thoniTUB · 2024-03-18T11:54:19Z

backend/src/main/java/com/bakdata/conquery/models/auth/AuthorizationController.java


+			// TODO necessary?
+			DefaultAuthFilter.registerTokenExtractor(JWTokenHandler.JWTokenExtractor.class, adminServlet.getJerseyConfig());


Einmal reicht eigentlich. kann dann aus dem if heraus

Die Frage hier ist ob ich den handler überhaupt regsitrieren darf/soll. Ich bin da nicht genug drin um zu wissen ob der per default immer registriert sein sollte.

Passt so wie es ist ich sortiere es noch

thoniTUB · 2024-03-18T12:00:05Z

backend/src/main/java/com/bakdata/conquery/models/auth/basic/JWTokenHandler.java

+	 * @return
+	 */
+	@Named("jwt-extractor")
+	@Service


Wenn es als Service annotiert ist, muss es dann noch programmatisch registriert werden?
Bisher waren die Extractors Singletons, da sie stateless sind können wir sie request scoped machen, damit sie nicht doch mal zufällig einen shared state haben.

backend/src/main/java/com/bakdata/conquery/models/auth/develop/UserIdTokenExtractor.java

backend/src/main/java/com/bakdata/conquery/models/auth/web/DefaultAuthFilter.java

thoniTUB · 2024-03-18T12:04:04Z

backend/src/main/java/com/bakdata/conquery/models/auth/web/DefaultAuthFilter.java

+	@Inject
+	@Setter
+	private IterableProvider<TokenExtractor> tokenExtractors;


Noice! Setter kann weg denke ich

thoniTUB · 2024-03-18T12:06:04Z

backend/src/main/java/com/bakdata/conquery/models/auth/web/DefaultAuthFilter.java

+	public static DefaultAuthFilter asDropwizardFeature() {
+		final DefaultAuthFilter authFilter =
+				new Builder()
+						.setAuthenticator(new ConqueryAuthenticator())
+						.setUnauthorizedHandler(new DefaultUnauthorizedHandler())
+						.buildAuthFilter();
+		return authFilter;
+	}


Müsen wir und auch noch mal anschauen. Das mit dem DropwizardFeature war immer irgendwie ein Umweg.
Ich weiß auch gerade nicht nicht warum es DynamicFeature in Jersey gibt, aber daher kam das glaube ich

Habe gerade nachgeschaut, das mit dem DynamicFeature nutzen wir nicht mehr und DropwizardFeature gibt es auch nicht mehr. Die Methode kann als eigentlich umbenannt werden.

thoniTUB · 2024-03-18T12:06:38Z

backend/src/main/java/com/bakdata/conquery/models/auth/web/DefaultAuthFilter.java

+	public static void registerTokenExtractor(Class<? extends TokenExtractor> extractor, ResourceConfig config) {
+		config.register(extractor);
+	}


Vielleicht nicht notwendig durch Service annotation

thoniTUB · 2024-03-18T12:10:09Z

backend/src/main/java/com/bakdata/conquery/models/auth/web/RedirectingAuthFilter.java

+		//TODO shouldn't this be something with NotAuthenticated?
+		catch (NotAuthorizedException e) {


Guter Punkt, aber das versammelt sich glaube ich unter der Exception

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

…-dependencies-4.0.6 # Conflicts: # backend/src/test/java/com/bakdata/conquery/integration/tests/ExternalFormBackendTest.java

thoniTUB · 2024-03-18T14:03:29Z

@awildturtok ich habe den konflikt beseitig und hoffentlich laufen jetzt die tests durch

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

…-dependencies-4.0.6

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

backend/src/main/java/com/bakdata/conquery/models/auth/web/AuthCookieFilter.java

backend/src/main/java/com/bakdata/conquery/models/auth/develop/DevAuthConfig.java

thoniTUB · 2024-03-21T08:30:13Z

backend/pom.xml

+        <dependency>
+            <groupId>jakarta.ws.rs</groupId>
+            <artifactId>jakarta.ws.rs-api</artifactId>
+            <version>3.1.0</version>
+        </dependency>


Das kann vielleicht raus ich probiere es mal

thoniTUB · 2024-03-21T08:41:19Z

backend/src/main/java/com/bakdata/conquery/models/auth/AuthorizationController.java


+			// TODO necessary?
+			DefaultAuthFilter.registerTokenExtractor(JWTokenHandler.JWTokenExtractor.class, adminServlet.getJerseyConfig());


Passt so wie es ist ich sortiere es noch

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

…-dependencies-4.0.6

dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 31, 2024

dependabot bot requested review from awildturtok and thoniTUB January 31, 2024 04:23

dependabot bot assigned awildturtok and thoniTUB Jan 31, 2024

dependabot bot mentioned this pull request Jan 31, 2024

Bump io.dropwizard:dropwizard-dependencies from 2.1.1 to 4.0.5 #3256

Closed

dependabot bot and others added 2 commits March 11, 2024 18:03

migrate to new bom deps

de9d875

awildturtok force-pushed the dependabot/maven/io.dropwizard-dropwizard-dependencies-4.0.6 branch from ae8fb2a to de9d875 Compare March 11, 2024 17:26

awildturtok added 3 commits March 13, 2024 10:19

brute force first impl to make DefaultAuthFilter work. RedirectingAut…

50231e8

…hFilter needs to be fixed next

cleanup TestLoggingFactory, strip of seemingly useless code

727f414

intermediate changes to make properly inject multiple TokenExtractor

c2b62ba

thoniTUB reviewed Mar 18, 2024

View reviewed changes

thoniTUB added 3 commits March 18, 2024 14:13

remove conflicting settings of default metrics registry

442017a

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

ignore fields from throwable in serdes

02fb6c1

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

Merge branch 'develop' into dependabot/maven/io.dropwizard-dropwizard…

98f7753

…-dependencies-4.0.6 # Conflicts: # backend/src/test/java/com/bakdata/conquery/integration/tests/ExternalFormBackendTest.java

thoniTUB added 6 commits March 18, 2024 15:11

remove Feature interface from AuthFilter

bcf7ada

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

wip make cypress tests pass

ba937db

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

make cypress tests pass

8380f3c

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

dev realm register token extractor only if admin servlet is present

af04d99

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

Merge branch 'develop' into dependabot/maven/io.dropwizard-dropwizard…

31e54d4

…-dependencies-4.0.6

make auth cookie filter stateless

0ee6519

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

awildturtok reviewed Mar 19, 2024

View reviewed changes

backend/src/main/java/com/bakdata/conquery/models/auth/web/AuthCookieFilter.java Outdated Show resolved Hide resolved

awildturtok reviewed Mar 19, 2024

View reviewed changes

backend/src/main/java/com/bakdata/conquery/models/auth/develop/DevAuthConfig.java Show resolved Hide resolved

thoniTUB added 2 commits March 21, 2024 11:00

review changes

8885f91

remove obsolete injection annotation

84154b9

fix admin ui login injection

dd583e7

thoniTUB reviewed Mar 21, 2024

View reviewed changes

thoniTUB and others added 3 commits March 21, 2024 11:49

fix injection of delegate auth filter

b689e4d

Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>

clean up auth filter registration

df631de

Merge branch 'develop' into dependabot/maven/io.dropwizard-dropwizard…

2e1b221

…-dependencies-4.0.6

thoniTUB approved these changes Apr 3, 2024

View reviewed changes

awildturtok merged commit c29bb50 into develop Apr 3, 2024
6 checks passed

delete-merged-branch bot deleted the dependabot/maven/io.dropwizard-dropwizard-dependencies-4.0.6 branch April 3, 2024 09:33

thoniTUB mentioned this pull request Apr 4, 2024

update superuser id in tutorial #3374

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump io.dropwizard:dropwizard-dependencies from 2.1.1 to 4.0.6 #3284

Bump io.dropwizard:dropwizard-dependencies from 2.1.1 to 4.0.6 #3284

dependabot bot commented on behalf of github Jan 31, 2024 •

edited

Loading

awildturtok commented Jan 31, 2024

dependabot bot commented on behalf of github Mar 7, 2024

thoniTUB left a comment

thoniTUB Mar 18, 2024

awildturtok Mar 18, 2024

thoniTUB Mar 21, 2024

thoniTUB Mar 18, 2024

thoniTUB Mar 18, 2024

thoniTUB Mar 18, 2024

thoniTUB Mar 18, 2024

thoniTUB Mar 18, 2024

thoniTUB Mar 18, 2024

thoniTUB commented Mar 18, 2024

thoniTUB Mar 21, 2024

thoniTUB Mar 21, 2024


		// TODO necessary?
		DefaultAuthFilter.registerTokenExtractor(JWTokenHandler.JWTokenExtractor.class, adminServlet.getJerseyConfig());

		//TODO shouldn't this be something with NotAuthenticated?
		catch (NotAuthorizedException e) {

Bump io.dropwizard:dropwizard-dependencies from 2.1.1 to 4.0.6 #3284

Bump io.dropwizard:dropwizard-dependencies from 2.1.1 to 4.0.6 #3284

Conversation

dependabot bot commented on behalf of github Jan 31, 2024 • edited Loading

awildturtok commented Jan 31, 2024

dependabot bot commented on behalf of github Mar 7, 2024

thoniTUB left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thoniTUB commented Mar 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Jan 31, 2024 •

edited

Loading