Implement Select filter value auto-completion for SQL mode #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
requested changes
Jan 24, 2024
| public class ClusterStorageHandler implements StorageHandler { | ||
|
|
||
| @Override | ||
| public List<String> lookupColumnValues(NamespaceStorage namespaceStorage, Column column) { |
There was a problem hiding this comment.
Hmmm, das darf glaube ich keine Liste sein, die sind riesig. Kriegst du das mit Streams implementiert?
| return ((StringStore) importColumn.getTypeDescription()).iterateValues(); | ||
| }) | ||
| storage.getStorageHandler() | ||
| .lookupColumnValues(storage, this).stream() |
There was a problem hiding this comment.
perfekt, du handlest das hier nur als stream weiter. Dann bitte auch als Stream ausgeben. Die haben potential riesig zu sein
| @@ -47,6 +48,11 @@ public class FilterAutocompleteTest extends IntegrationTest.Simple implements Pr | |||
| "b,lbl-6,ov-6" | |||
| }; | |||
|
|
|||
| @Override | |||
| public Set<StandaloneSupport.Mode> forModes() { | |||
| return Set.of(StandaloneSupport.Mode.WORKER, StandaloneSupport.Mode.SQL); | |||
awildturtok
approved these changes
Jan 24, 2024
backend/src/main/java/com/bakdata/conquery/mode/local/SqlStorageHandler.java
Outdated
Show resolved
Hide resolved
…geHandler.java Co-authored-by: awildturtok <1553491+awildturtok@users.noreply.github.com>
delete-merged-branch
bot
deleted the
sql/feature/sql-filter-value-autocompletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.