Add COUNT_QUARTERS SQL conversion for DATE columns #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsrnhld
force-pushed
the
sql/feature/count-quarters
branch
from
d21f73c to
af01524
Compare
awildturtok
requested changes
Jan 8, 2024
...nd/src/main/java/com/bakdata/conquery/sql/conversion/dialect/PostgreSqlFunctionProvider.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * @return The numerical year and quarter of the given date column as "yyyy-Qx" string expression with x being the quarter. | ||
| */ | ||
| Field<String> quartersPerYear(Field<Date> dateField); |
There was a problem hiding this comment.
der name ist recht ungeschickt gewählt, ich hab das einfach YearQuarter genannt. quartersInYear ist ein anderer Select, der die Quartale in einem Jahr zählt.
There was a problem hiding this comment.
@jnsrnhld der PR ist noch offen, kannst du das bitte fixen, dann kann auch gemerged werden.
There was a problem hiding this comment.
Sorry, ich dachte ich hätte das längst gemacht - hab es jetzt nachgeholt!
Base automatically changed from
sql/feature/complete-sum-conversion
to
develop
January 9, 2024 11:58
awildturtok
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wie erwähnt: Die Conversion von COUNT_QUARTERS auf DATE_RANGE Columns für HANA wird aufwändig, daher erstmal nur für einfache DATE columns.