Skip to content

Commit

Permalink
fixes width calculation
Browse files Browse the repository at this point in the history
  • Loading branch information
awildturtok committed Jan 3, 2024
1 parent 03a97b1 commit b3962a7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
import lombok.Data;

@Data
public class DynamicHistogram {
public class BalancingStaticHistogram {
private final Node[] nodes;
private final double min;
private final double width;

public static DynamicHistogram create(double min, double max, int expectedBins) {
return new DynamicHistogram(new Node[expectedBins], min, (max - min) / expectedBins);
public static BalancingStaticHistogram create(double min, double max, int expectedBins) {
return new BalancingStaticHistogram(new Node[expectedBins], min, (max - min) / (expectedBins - 1));
}

public void add(double value) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,17 +94,17 @@ public ResultColumnStatistics describe() {

@NotNull
private List<StringColumnStatsCollector.ColumnDescription.Entry> createBins(int total, int expectedBins) {
final DynamicHistogram histogram = DynamicHistogram.create(getStatistics().getMin(), getStatistics().getMax(), expectedBins);
final BalancingStaticHistogram histogram = BalancingStaticHistogram.create(getStatistics().getMin(), getStatistics().getMax(), expectedBins);

Arrays.stream(getStatistics().getValues()).forEach(histogram::add);

final List<DynamicHistogram.Node> balanced = histogram.balanced(expectedBins, total);
final List<BalancingStaticHistogram.Node> balanced = histogram.balanced(expectedBins, total);


final List<StringColumnStatsCollector.ColumnDescription.Entry> entries = new ArrayList<>();


for (DynamicHistogram.Node bin : balanced) {
for (BalancingStaticHistogram.Node bin : balanced) {
final String lower = printValue(bin.getMin());
final String upper = printValue(bin.getMax());

Expand Down

0 comments on commit b3962a7

Please sign in to comment.