Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at resolving the snmp test failures #166

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

First pass at resolving the snmp test failures #166

wants to merge 17 commits into from

Conversation

elfiesmelfie
Copy link
Collaborator

@elfiesmelfie elfiesmelfie commented Oct 29, 2024 •
edited
Loading

The issue may have been caused by the observability strategy tests causing both community and redhat monitoring components to be installed and shadowing the monitoring component definitions (prom, alertmanager, etc)

Depends-On: #177

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 2 times, most recently from b8ffcb7 to ff8ef96 Compare October 31, 2024 18:57
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 3 times, most recently from 9f933df to 3fda2d0 Compare November 19, 2024 20:53
@elfiesmelfie
Copy link
Collaborator Author

recheck

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 6 times, most recently from 17863ff to 91990e9 Compare November 27, 2024 20:08
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 6 times, most recently from 8353e87 to 2503c4a Compare December 5, 2024 13:51
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,2503c4afab8eaa204bbd76b3b965a57f513aa587

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from 2503c4a to a381325 Compare December 5, 2024 17:52
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,a9a04c5158b0739624dadb794aa87b11cc5ac99b

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 4 times, most recently from de97212 to 2d46452 Compare December 10, 2024 18:41
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,119f7197dd557f8a5d286d7fb156f21bafc4e272

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,08ab06b0d20b820c0ec450c661ede3ba2f793bda

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from 08ab06b to 410547e Compare December 17, 2024 16:30
mgirgisf and others added 15 commits December 17, 2024 18:07
@mgirgisf @elfiesmelfie
Test with logging job
aa75b8e
@mgirgisf @elfiesmelfie
rm the Debug msg
d25e5f0
@elfiesmelfie
[test_snmp_traps] Add debug after a failure
d9ab2d3 
Use rescue to provide additional information when the test fails
@elfiesmelfie
[test_alerts] Update alertmanager test
9d99f2d 
* update block contents
* add always for cleanup tasks
* Replace wait with a continuous check
@elfiesmelfie
Update test_alerts
6075e73 
* Update the alarm to use "fvt-tests" in the name and FVT_TESTING in the
  alarm description so we can identify the alarm created by this test
* Delete the prometheusrule when the test is over

* Correct the failed_when condition to match the alarm message
* Update the check for the alarm to wait for up to 2 minutes.
* Update timeout on alarm creation add a check for deletion
@elfiesmelfie
[test_snmp_traps] Remove grep and update failed_when
8e80319
@elfiesmelfie
[test_alerts] Update pre- and post-test tasks
89e7bd9 
* Name the alarm for tracability
* Retry the check for alarm creation
* Add check for Prometheus rule deletion
@elfiesmelfie
[test_alerts] Fix ansible-lint errors
7dd91b2
@elfiesmelfie
[test_verify_email] Add quotes to the receiver name
a3b8981 
This avoids some errors in parsing the alertmanager config, which caused delays and the alarm not to appear in the logs
@elfiesmelfie
[test_snmp_traps] Undo update to stf object post-test
272e113
@elfiesmelfie
[test_snmp_traps] Add a meaningful changed_when for oc patch
56909b0
@elfiesmelfie
[temp][test_sensubility] Add more detail to the healthcheck
aa6debe
@elfiesmelfie
[test_snmp_traps] Add a task to get prom creds at the start of the test
8b8a13e
@elfiesmelfie
[test_snmp_traps] Wait up to two minutes for the snmp logs to show th…
d44b7ee 
…e alarm
@elfiesmelfie
[test_alerts] Remove duplicate testcase
3190efb
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from 410547e to 3190efb Compare December 17, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elfiesmelfie @mgirgisf