feat: link the pr to solved jira #897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the PR message contains a (re-)solves reference to a JIRA issue. The add-jira-link-pr-open.yml GitHub action will create a link in JIRA to this PR. Resolves PZ-2089
bas-info-nl
requested review from
hsiliev,
felixcicatt and
a team
as code owners
hsiliev
approved these changes
Apr 15, 2024
| - name: Run Python script | ||
| run: | | ||
| pip install requests | ||
| MY_PYTHON_SCRIPT=$(cat << EOF |
There was a problem hiding this comment.
Do we need MY_PYTHON_SCRIPT? Can we execute this directly with python as we anyway immediately do?
There was a problem hiding this comment.
We need some variable substitutions, but you might be right, and it could be executed directly, without going through a local variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the PR message contains a (re-)solves reference to a JIRA issue. The add-jira-link-pr-open.yml GitHub action will create a link in JIRA to this PR.
Resolves PZ-2089