Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PZ-2089 - link the pr to solved jira #886

Closed
wants to merge 1 commit into from
Closed

Conversation

bas-info-nl
Copy link
Member

Create new actions pipeline; add-jira-link-pr-open.yml, that will add a link in Jira back to the PR that this is triggered on.

Add some sample .secrets-sample and a sample pull-request-event.json for testing the pipeline code. And mention this in the relevant README.md.

Resolves PZ-2089

Create new actions pipeline; add-jira-link-pr-open.yml, that will add a link in Jira back to the PR that this is triggered on.

Add some sample .secrets-sample and a sample pull-request-event.json for testing the pipeline code. And mention this in the relevant README.md.
@bas-info-nl bas-info-nl requested review from hsiliev, felixcicatt and a team as code owners April 11, 2024 16:18
Copy link
Contributor

unit-test-results

 25 files  ±0   48 suites  ±0   1m 36s ⏱️ -1s
148 tests ±0  147 ✅ ±0  1 💤 ±0  0 ❌ ±0 
171 runs  ±0  169 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 0f48ad3. ± Comparison against base commit 7562642.

Copy link
Contributor

integration-test-results

11 files  ±0  11 suites  ±0   14s ⏱️ ±0s
43 tests ±0  43 ✅ ±0  0 💤 ±0  0 ❌ ±0 
48 runs  ±0  48 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0f48ad3. ± Comparison against base commit 7562642.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.55%. Comparing base (28e81f5) to head (0f48ad3).
Report is 132 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #886      +/-   ##
============================================
+ Coverage     30.18%   34.55%   +4.36%     
- Complexity     1565     1883     +318     
============================================
  Files           897      913      +16     
  Lines         17285    18167     +882     
  Branches       1220     1256      +36     
============================================
+ Hits           5217     6277    +1060     
+ Misses        11594    11488     -106     
+ Partials        474      402      -72     
Flag Coverage Δ
integrationtests 32.69% <ø> (+5.20%) ⬆️
unittests 15.64% <ø> (+2.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@edgarvonk edgarvonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. But why would we want this? It does add quite some complexity and therefore potential maintenance (if it ever breaks down, does not work correctly etc).

Personally, but maybe that's just me, I never understood why you would want to link back from an issue management system like JIRA back to Git.. ;-)

@edgarvonk
Copy link
Member

Don't get me wrong: it's an impressive piece of code. :-) I just don't see the benefit personally.

And I'm a bit surprised that there isn't already a GitHub out there that does this? If there isn't, maybe consider making this code into an open source GitHub Action project, instead of embedding it into this project?

@bas-info-nl bas-info-nl deleted the feat/link_pr_in_jira branch April 12, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants