Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helm chart release workflow #2436

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Conversation

niorg
Copy link
Member

@niorg niorg commented Jan 17, 2025

Add helm chart release flow to gh-pages

Also moved helm charts to charts directory as it is expected there.

Fixed some linting and deployment errors along too

Solves PZ-4965

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2291 files.

Valid Invalid Ignored Fixed
2021 19 251 0
Click to see the invalid file list
  • charts/zac/Chart.lock
  • charts/zac/templates/_helpers.tpl
  • charts/zac/templates/config.yaml
  • charts/zac/templates/configmap-nginx.yaml
  • charts/zac/templates/deployment.yaml
  • charts/zac/templates/extra-deploy.yaml
  • charts/zac/templates/hpa.yaml
  • charts/zac/templates/ingress.yaml
  • charts/zac/templates/nginx-deployment.yaml
  • charts/zac/templates/nginx-service.yaml
  • charts/zac/templates/office-converter-deployment.yaml
  • charts/zac/templates/office-converter-service.yaml
  • charts/zac/templates/opa-deployment.yaml
  • charts/zac/templates/opa-service.yaml
  • charts/zac/templates/secret.yaml
  • charts/zac/templates/service.yaml
  • charts/zac/templates/serviceaccount.yaml
  • charts/zac/templates/signaleren-cron-job.yaml
  • charts/zac/templates/signaleren-delete-cron-job.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2288 files.

Valid Invalid Ignored Fixed
2018 19 251 0
Click to see the invalid file list
  • charts/zac/Chart.lock
  • charts/zac/templates/_helpers.tpl
  • charts/zac/templates/config.yaml
  • charts/zac/templates/configmap-nginx.yaml
  • charts/zac/templates/deployment.yaml
  • charts/zac/templates/extra-deploy.yaml
  • charts/zac/templates/hpa.yaml
  • charts/zac/templates/ingress.yaml
  • charts/zac/templates/nginx-deployment.yaml
  • charts/zac/templates/nginx-service.yaml
  • charts/zac/templates/office-converter-deployment.yaml
  • charts/zac/templates/office-converter-service.yaml
  • charts/zac/templates/opa-deployment.yaml
  • charts/zac/templates/opa-service.yaml
  • charts/zac/templates/secret.yaml
  • charts/zac/templates/service.yaml
  • charts/zac/templates/serviceaccount.yaml
  • charts/zac/templates/signaleren-cron-job.yaml
  • charts/zac/templates/signaleren-delete-cron-job.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

github-actions bot commented Jan 17, 2025

unit-test-results

 78 files  105 suites   2m 3s ⏱️
365 tests 364 ✅ 1 💤 0 ❌
455 runs  453 ✅ 2 💤 0 ❌

Results for commit 8b0e7be.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2288 files.

Valid Invalid Ignored Fixed
2018 19 251 0
Click to see the invalid file list
  • charts/zac/Chart.lock
  • charts/zac/templates/_helpers.tpl
  • charts/zac/templates/config.yaml
  • charts/zac/templates/configmap-nginx.yaml
  • charts/zac/templates/deployment.yaml
  • charts/zac/templates/extra-deploy.yaml
  • charts/zac/templates/hpa.yaml
  • charts/zac/templates/ingress.yaml
  • charts/zac/templates/nginx-deployment.yaml
  • charts/zac/templates/nginx-service.yaml
  • charts/zac/templates/office-converter-deployment.yaml
  • charts/zac/templates/office-converter-service.yaml
  • charts/zac/templates/opa-deployment.yaml
  • charts/zac/templates/opa-service.yaml
  • charts/zac/templates/secret.yaml
  • charts/zac/templates/service.yaml
  • charts/zac/templates/serviceaccount.yaml
  • charts/zac/templates/signaleren-cron-job.yaml
  • charts/zac/templates/signaleren-delete-cron-job.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2288 files.

Valid Invalid Ignored Fixed
2018 19 251 0
Click to see the invalid file list
  • charts/zac/Chart.lock
  • charts/zac/templates/_helpers.tpl
  • charts/zac/templates/config.yaml
  • charts/zac/templates/configmap-nginx.yaml
  • charts/zac/templates/deployment.yaml
  • charts/zac/templates/extra-deploy.yaml
  • charts/zac/templates/hpa.yaml
  • charts/zac/templates/ingress.yaml
  • charts/zac/templates/nginx-deployment.yaml
  • charts/zac/templates/nginx-service.yaml
  • charts/zac/templates/office-converter-deployment.yaml
  • charts/zac/templates/office-converter-service.yaml
  • charts/zac/templates/opa-deployment.yaml
  • charts/zac/templates/opa-service.yaml
  • charts/zac/templates/secret.yaml
  • charts/zac/templates/service.yaml
  • charts/zac/templates/serviceaccount.yaml
  • charts/zac/templates/signaleren-cron-job.yaml
  • charts/zac/templates/signaleren-delete-cron-job.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

github-actions bot commented Jan 17, 2025

integration-test-results

 27 files   27 suites   35s ⏱️
106 tests 106 ✅ 0 💤 0 ❌
119 runs  119 ✅ 0 💤 0 ❌

Results for commit 8b0e7be.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.76%. Comparing base (51202a6) to head (8b0e7be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2436   +/-   ##
=========================================
  Coverage     52.76%   52.76%           
  Complexity     3262     3262           
=========================================
  Files           991      991           
  Lines         22519    22519           
  Branches       1718     1718           
=========================================
  Hits          11883    11883           
  Misses         9862     9862           
  Partials        774      774           
Flag Coverage Δ
integrationtests 49.20% <ø> (ø)
unittests 33.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niorg niorg force-pushed the feature/helm-chart-release-workflow branch from a891cc7 to 8b0e7be Compare January 17, 2025 14:49
@niorg niorg marked this pull request as ready for review January 17, 2025 14:49
@niorg niorg requested review from hsiliev and a team as code owners January 17, 2025 14:49
@infojohn
Copy link
Contributor

when we merge we have to change some other pipelines in provisioning...

@niorg
Copy link
Member Author

niorg commented Jan 17, 2025

yes, we need to be careful with merging until all is aligned. Also renaming the gh-pages branch and modify branch protection rules needs to be done prior to merging this.

@niorg niorg added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 62a605e Jan 20, 2025
26 checks passed
@niorg niorg deleted the feature/helm-chart-release-workflow branch January 20, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants