-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helm chart release workflow #2436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2291 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2021 | 19 | 251 | 0 |
Click to see the invalid file list
- charts/zac/Chart.lock
- charts/zac/templates/_helpers.tpl
- charts/zac/templates/config.yaml
- charts/zac/templates/configmap-nginx.yaml
- charts/zac/templates/deployment.yaml
- charts/zac/templates/extra-deploy.yaml
- charts/zac/templates/hpa.yaml
- charts/zac/templates/ingress.yaml
- charts/zac/templates/nginx-deployment.yaml
- charts/zac/templates/nginx-service.yaml
- charts/zac/templates/office-converter-deployment.yaml
- charts/zac/templates/office-converter-service.yaml
- charts/zac/templates/opa-deployment.yaml
- charts/zac/templates/opa-service.yaml
- charts/zac/templates/secret.yaml
- charts/zac/templates/service.yaml
- charts/zac/templates/serviceaccount.yaml
- charts/zac/templates/signaleren-cron-job.yaml
- charts/zac/templates/signaleren-delete-cron-job.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2288 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2018 | 19 | 251 | 0 |
Click to see the invalid file list
- charts/zac/Chart.lock
- charts/zac/templates/_helpers.tpl
- charts/zac/templates/config.yaml
- charts/zac/templates/configmap-nginx.yaml
- charts/zac/templates/deployment.yaml
- charts/zac/templates/extra-deploy.yaml
- charts/zac/templates/hpa.yaml
- charts/zac/templates/ingress.yaml
- charts/zac/templates/nginx-deployment.yaml
- charts/zac/templates/nginx-service.yaml
- charts/zac/templates/office-converter-deployment.yaml
- charts/zac/templates/office-converter-service.yaml
- charts/zac/templates/opa-deployment.yaml
- charts/zac/templates/opa-service.yaml
- charts/zac/templates/secret.yaml
- charts/zac/templates/service.yaml
- charts/zac/templates/serviceaccount.yaml
- charts/zac/templates/signaleren-cron-job.yaml
- charts/zac/templates/signaleren-delete-cron-job.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
unit-test-results 78 files 105 suites 2m 3s ⏱️ Results for commit 8b0e7be. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2288 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2018 | 19 | 251 | 0 |
Click to see the invalid file list
- charts/zac/Chart.lock
- charts/zac/templates/_helpers.tpl
- charts/zac/templates/config.yaml
- charts/zac/templates/configmap-nginx.yaml
- charts/zac/templates/deployment.yaml
- charts/zac/templates/extra-deploy.yaml
- charts/zac/templates/hpa.yaml
- charts/zac/templates/ingress.yaml
- charts/zac/templates/nginx-deployment.yaml
- charts/zac/templates/nginx-service.yaml
- charts/zac/templates/office-converter-deployment.yaml
- charts/zac/templates/office-converter-service.yaml
- charts/zac/templates/opa-deployment.yaml
- charts/zac/templates/opa-service.yaml
- charts/zac/templates/secret.yaml
- charts/zac/templates/service.yaml
- charts/zac/templates/serviceaccount.yaml
- charts/zac/templates/signaleren-cron-job.yaml
- charts/zac/templates/signaleren-delete-cron-job.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2288 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2018 | 19 | 251 | 0 |
Click to see the invalid file list
- charts/zac/Chart.lock
- charts/zac/templates/_helpers.tpl
- charts/zac/templates/config.yaml
- charts/zac/templates/configmap-nginx.yaml
- charts/zac/templates/deployment.yaml
- charts/zac/templates/extra-deploy.yaml
- charts/zac/templates/hpa.yaml
- charts/zac/templates/ingress.yaml
- charts/zac/templates/nginx-deployment.yaml
- charts/zac/templates/nginx-service.yaml
- charts/zac/templates/office-converter-deployment.yaml
- charts/zac/templates/office-converter-service.yaml
- charts/zac/templates/opa-deployment.yaml
- charts/zac/templates/opa-service.yaml
- charts/zac/templates/secret.yaml
- charts/zac/templates/service.yaml
- charts/zac/templates/serviceaccount.yaml
- charts/zac/templates/signaleren-cron-job.yaml
- charts/zac/templates/signaleren-delete-cron-job.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
integration-test-results 27 files 27 suites 35s ⏱️ Results for commit 8b0e7be. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2436 +/- ##
=========================================
Coverage 52.76% 52.76%
Complexity 3262 3262
=========================================
Files 991 991
Lines 22519 22519
Branches 1718 1718
=========================================
Hits 11883 11883
Misses 9862 9862
Partials 774 774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a891cc7
to
8b0e7be
Compare
when we merge we have to change some other pipelines in provisioning... |
yes, we need to be careful with merging until all is aligned. Also renaming the gh-pages branch and modify branch protection rules needs to be done prior to merging this. |
Add helm chart release flow to gh-pages
Also moved helm charts to
charts
directory as it is expected there.Fixed some linting and deployment errors along too
Solves PZ-4965