Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FE - reduce size of spinner to fit in its box #2273

Merged

Conversation

infonl-marcel
Copy link
Contributor

FE - reduce size of spinner to fit in its box. Available box space is 17.9883px. So took 18px.

Solves PZ-4454

@infonl-marcel infonl-marcel requested review from hsiliev and a team as code owners December 18, 2024 17:06
Copy link
Contributor

unit-test-results

 75 files  102 suites   2m 1s ⏱️
345 tests 344 ✅ 1 💤 0 ❌
425 runs  423 ✅ 2 💤 0 ❌

Results for commit 997efbe.

Copy link
Contributor

integration-test-results

 27 files   27 suites   31s ⏱️
105 tests 105 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit 997efbe.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.96%. Comparing base (39441bb) to head (997efbe).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2273   +/-   ##
=========================================
  Coverage     51.96%   51.96%           
  Complexity     3168     3168           
=========================================
  Files           998      998           
  Lines         22516    22516           
  Branches       1654     1654           
=========================================
  Hits          11700    11700           
  Misses        10085    10085           
  Partials        731      731           
Flag Coverage Δ
integrationtests 48.87% <ø> (ø)
unittests 32.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@edgarvonk edgarvonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinnin'

@infonl-marcel infonl-marcel added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 1ea523d Dec 18, 2024
23 checks passed
@infonl-marcel infonl-marcel deleted the feat/PZ-4454--FE--fix-too-less-space-for-spinner branch December 18, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants