Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reverted adding SPDX headers to Helm Chart files because that breaks our deployment script #2201

Conversation

edgarvonk
Copy link
Member

Reverted adding SPDX headers to Helm Chart files because that breaks our deployment script. The 'Bake deployment' provisioning step failed because it generates a corrupt Helm Chart file with SPDX headers:

# Source: zaakafhandelcomponent/templates/serviceaccount.yaml
#
# SPDX-FileCopyrightText: 2022 Atos, 2024 Lifely
# SPDX-License-Identifier: EUPL-1.2+
#apiVersion: v1
kind: ServiceAccount
metadata:
  name: zac-dev-zaakafhandelcomponent

Solves PZ-4778

@edgarvonk edgarvonk requested review from hsiliev and a team as code owners December 4, 2024 18:25
@edgarvonk edgarvonk enabled auto-merge December 4, 2024 18:25
Copy link
Contributor

github-actions bot commented Dec 4, 2024

unit-test-results

 72 files   99 suites   2m 0s ⏱️
340 tests 339 ✅ 1 💤 0 ❌
407 runs  405 ✅ 2 💤 0 ❌

Results for commit a6f2087.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

integration-test-results

 27 files   27 suites   34s ⏱️
105 tests 105 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit a6f2087.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.77%. Comparing base (5f4b9ce) to head (a6f2087).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2201    +/-   ##
==========================================
  Coverage     51.77%   51.77%            
  Complexity     3142     3142            
==========================================
  Files           993      993            
  Lines         22426    22426            
  Branches       1639     1671    +32     
==========================================
  Hits          11612    11612            
+ Misses        10089     9967   -122     
- Partials        725      847   +122     
Flag Coverage Δ
integrationtests 48.79% <ø> (ø)
unittests 31.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarvonk edgarvonk assigned edgarvonk and unassigned edgarvonk Dec 4, 2024
@edgarvonk edgarvonk added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 3cc17a7 Dec 5, 2024
23 checks passed
@edgarvonk edgarvonk deleted the feature/PZ-4778-revert-adding-spdx-headers-to-helm-chart-files branch December 5, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants