Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert changes made in PZ-4521 in the ZaakafhandelParameterBeheerService.kt #2197

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

edgarvonk
Copy link
Member

Reverted changes made in PZ-4521 in the ZaakafhandelParameterBeheerService.kt to see if that solves an issue where new zaakafhandelparameters created from a new zaaktype are sometimes empty.

Solves PZ-4521

@edgarvonk edgarvonk requested review from hsiliev and a team as code owners December 4, 2024 15:31
…eerService.kt to see if that solves an issue where new zaakafhandelparameters created from a new zaaktype are sometimes empty
@edgarvonk edgarvonk force-pushed the feature/PZ-4774-revert-PZ-4521-changes branch from 641551d to 0fc091e Compare December 4, 2024 15:34
Copy link
Contributor

github-actions bot commented Dec 4, 2024

unit-test-results

 72 files   99 suites   2m 4s ⏱️
339 tests 338 ✅ 1 💤 0 ❌
406 runs  404 ✅ 2 💤 0 ❌

Results for commit 0fc091e.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

integration-test-results

 27 files   27 suites   33s ⏱️
105 tests 105 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit 0fc091e.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 27.77778% with 26 lines in your changes missing coverage. Please review.

Project coverage is 51.60%. Comparing base (6e9877b) to head (0fc091e).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...os/zac/admin/ZaakafhandelParameterBeheerService.kt 28.57% 24 Missing and 1 partial ⚠️
...net/atos/zac/notificaties/NotificatieReceiver.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2197      +/-   ##
============================================
- Coverage     51.78%   51.60%   -0.18%     
+ Complexity     3142     3134       -8     
============================================
  Files           993      993              
  Lines         22428    22427       -1     
  Branches       1639     1664      +25     
============================================
- Hits          11614    11574      -40     
+ Misses        10089    10008      -81     
- Partials        725      845     +120     
Flag Coverage Δ
integrationtests 48.82% <25.00%> (+0.03%) ⬆️
unittests 31.20% <16.66%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarvonk edgarvonk added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 2e9d29b Dec 5, 2024
21 of 23 checks passed
@edgarvonk edgarvonk deleted the feature/PZ-4774-revert-PZ-4521-changes branch December 5, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants