Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FE - Taak detail - Show Document Create button only when SmartDocuments is enabled #2192

Merged

Conversation

infonl-marcel
Copy link
Contributor

@infonl-marcel infonl-marcel commented Dec 4, 2024

FE - Taak detail - Show Document Create button only when SmartDocuments is enabled

The Zaak data is loaded after Taak data is loaded; so that is why there is a menu update needed. Discussed with Karin about order of buttons; Create should be the bottom one.

Solves PZ-3406

@infonl-marcel infonl-marcel requested review from hsiliev and a team as code owners December 4, 2024 12:15
Copy link
Contributor

github-actions bot commented Dec 4, 2024

unit-test-results

 72 files   99 suites   2m 0s ⏱️
340 tests 339 ✅ 1 💤 0 ❌
407 runs  405 ✅ 2 💤 0 ❌

Results for commit 48158aa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

integration-test-results

 27 files   27 suites   34s ⏱️
105 tests 105 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit 48158aa.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.78%. Comparing base (b68de91) to head (48158aa).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...app/src/app/taken/taak-view/taak-view.component.ts 33.33% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2192      +/-   ##
============================================
+ Coverage     51.59%   51.78%   +0.18%     
+ Complexity     3143     3142       -1     
============================================
  Files           995      993       -2     
  Lines         22442    22429      -13     
  Branches       1671     1639      -32     
============================================
+ Hits          11580    11615      +35     
- Misses        10013    10089      +76     
+ Partials        849      725     -124     
Flag Coverage Δ
integrationtests 48.79% <ø> (-0.03%) ⬇️
unittests 31.45% <33.33%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@infonl-marcel infonl-marcel requested a review from xiduzo December 4, 2024 12:49
@infonl-marcel infonl-marcel added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 8c4cc05 Dec 4, 2024
23 of 24 checks passed
@infonl-marcel infonl-marcel deleted the feat/PZ-3406--FE--conditional-document-create-buttons branch December 4, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants