Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added correct quoting #2175

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix: added correct quoting #2175

merged 2 commits into from
Dec 2, 2024

Conversation

infojohn
Copy link
Contributor

@infojohn infojohn commented Dec 2, 2024

Solves PZ-3409

stupid helm template

@infojohn infojohn requested review from hsiliev and a team as code owners December 2, 2024 13:54
@infojohn infojohn enabled auto-merge December 2, 2024 14:02
Copy link
Contributor

github-actions bot commented Dec 2, 2024

unit-test-results

 72 files   99 suites   2m 3s ⏱️
334 tests 333 ✅ 1 💤 0 ❌
400 runs  398 ✅ 2 💤 0 ❌

Results for commit e381278.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

integration-test-results

 27 files   27 suites   35s ⏱️
105 tests 105 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit e381278.

@infojohn infojohn added this pull request to the merge queue Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.54%. Comparing base (53305cc) to head (e381278).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2175    +/-   ##
==========================================
  Coverage     51.54%   51.54%            
  Complexity     3137     3137            
==========================================
  Files           996      996            
  Lines         22427    22427            
  Branches       1633     1665    +32     
==========================================
  Hits          11559    11559            
+ Misses        10141    10019   -122     
- Partials        727      849   +122     
Flag Coverage Δ
integrationtests 48.74% <ø> (ø)
unittests 31.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bas-info-nl bas-info-nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might be other values that need to be quoted ?

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@hsiliev hsiliev added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 616fdaf Dec 2, 2024
23 checks passed
@hsiliev hsiliev deleted the fix/PZ-3409-quote-boolean branch December 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants