Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: corrected boolean handling and set false by default #2174

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

infojohn
Copy link
Contributor

@infojohn infojohn commented Dec 2, 2024

Solves PZ-3409

@infojohn infojohn requested review from hsiliev and a team as code owners December 2, 2024 13:12
Copy link
Member

@edgarvonk edgarvonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@hsiliev hsiliev enabled auto-merge December 2, 2024 13:17
Copy link
Contributor

github-actions bot commented Dec 2, 2024

unit-test-results

 72 files   99 suites   2m 2s ⏱️
334 tests 333 ✅ 1 💤 0 ❌
400 runs  398 ✅ 2 💤 0 ❌

Results for commit 5482f67.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

integration-test-results

 27 files   27 suites   34s ⏱️
105 tests 105 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit 5482f67.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.54%. Comparing base (c99c9d0) to head (5482f67).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2174    +/-   ##
==========================================
  Coverage     51.54%   51.54%            
  Complexity     3137     3137            
==========================================
  Files           996      996            
  Lines         22427    22427            
  Branches       1658     1633    -25     
==========================================
  Hits          11559    11559            
- Misses        10019    10141   +122     
+ Partials        849      727   -122     
Flag Coverage Δ
integrationtests 48.74% <ø> (ø)
unittests 31.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsiliev hsiliev added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 53305cc Dec 2, 2024
23 checks passed
@hsiliev hsiliev deleted the fix/PZ-3409-use-boolean-correctly branch December 2, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants