Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FE - add no document type option to deselect #2173

Merged

Conversation

infonl-marcel
Copy link
Contributor

FE - add no document type option to deselect

Solves PZ-4726

@infonl-marcel infonl-marcel requested review from hsiliev and a team as code owners December 2, 2024 11:54
@bas-info-nl
Copy link
Member

Failing build ?

Copy link
Contributor

github-actions bot commented Dec 2, 2024

unit-test-results

 72 files   99 suites   2m 2s ⏱️
334 tests 333 ✅ 1 💤 0 ❌
400 runs  398 ✅ 2 💤 0 ❌

Results for commit 555b15b.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

integration-test-results

 27 files   27 suites   34s ⏱️
105 tests 105 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit 555b15b.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.54%. Comparing base (aedebaf) to head (555b15b).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2173    +/-   ##
==========================================
  Coverage     51.54%   51.54%            
  Complexity     3137     3137            
==========================================
  Files           996      996            
  Lines         22427    22427            
  Branches       1633     1665    +32     
==========================================
  Hits          11559    11559            
+ Misses        10141    10019   -122     
- Partials        727      849   +122     
Flag Coverage Δ
integrationtests 48.74% <ø> (ø)
unittests 31.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@infonl-marcel infonl-marcel added this pull request to the merge queue Dec 2, 2024
@infonl-marcel
Copy link
Contributor Author

Failing build ?

formatting needed @bas-info-nl

Merged via the queue into main with commit 54fd3f7 Dec 2, 2024
23 checks passed
@infonl-marcel infonl-marcel deleted the feat/PZ-4726--FE--add-no-document-type-option-to-deselect branch December 2, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants