Soul Fire'd API integration (1.19.2) #443
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soul Fire'd is a mod of mine with a dual aim:
I saw that Infernal Expansion can benefit in both cases as it currently is:
By integrating the Soul Fire'd API, Infernal Expansion gets more streamlined code, removal of some mixins, easier fire handling, and more optional features (e.g. enchantments handling, easy fire source and campfire handling, etc.).
Furthermore, Vanilla fire and soul fire are already handled without needing explicit references in your code.
I also plan to expand the ecosystem with further PRs to other mods, such that they are all compatible with each other and there's less need for you to register others' fires.
If this PR is accepted, I will also start working for 1.16.5 and 1.18.2 PRs (or for whichever branch is better, maybe release-3.0?).
Lastly, I know it's not always the best to add dependency to other mods as that might slow down future versions rollouts, but I can assure you, as the Soul Fire'd API developer, that it's always going to come out very soon for newer versions (and you can already see it by the wide range of Minecraft versions supported and actively mantained).
Let me know if I did anything wrong when contributing or if something is not clear, or really anything in general.
Changes summary:
build.gradle
Added Soul Fire'd dependency.
Mixins
Removed
MixinEntityRendererManager
,MixinOverlayRenderer
, andMixinEntity
.Changed
MixinModelBakery
andMixinAbstractFireBlock
(removed now useless bits).Old fire internal API
Removed
FireTypeAccess
,FireType
, andClientFireType
.Changed registration of fires in
IEFireTypes
.