Upgraded Kubernetes support to 1.16.3 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andor
reviewed
Feb 7, 2020
| tolerations: | ||
| - operator: Exists | ||
| effect: NoSchedule | ||
| serviceAccountName: flannel | ||
| initContainers: | ||
| - name: install-cni | ||
| image: quay.io/coreos/flannel:{{.flannel_image_version}}-amd64 |
There was a problem hiding this comment.
Maybe you want to keep templating like this one?
There was a problem hiding this comment.
I've removed the hardcoded values here: DGollings#1
There was a problem hiding this comment.
Yes, the templates must be kept in order to configure things...
There was a problem hiding this comment.
I can make a new PR with @DGollings changes and mine if you want
There was a problem hiding this comment.
@pablokbs apologies for the dealy in my response. That would be perfect, I think that the only requirement would be to keep these files as templates, as the provider uses them for replacing all the values configured in Terraform...
This was referenced Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to run Kubernetes on Upcloud vm's, cool Terraform script, thanks :)
Can confirm that it works, well, boots without issues, with ubuntu 18.04
Updated Kubernetes support to 1.16.3 and anything related (mostly Helm/Flannel)
(It's very likely that Weave also needs updating)