Make the Debugger a singleton and do not reset the stopframe to None during postmortem. #667
Conversation
…during postmortem. This fixes inducer#607. Making the Debugger a singleton should be enough to fix inducer#607. HOWEVER, pytest def postmortem() calls .reset() which resets the stopframe. Somehow, this causes the debugger to stop somewhere inside internal debugger source code, instead of in the code the postmortem should be done. So, this also includes an override of the .reset() method and detects when the debugger is already running and does not reset the stopframe. See also inducer#67.
|
Reproduce issue. Install pytest and pudb.
def test_foo():
breakpoint()
raise Exceptionpytest --pdbcls pudb.debugger:Debugger --pdb --capture=no test.pyNB. The stopframe issue (#52) can also be observed with pytest-pudb using pytest --pudb test.py |
pudb/debugger.py
Outdated
| import linecache | ||
| linecache.checkcache() | ||
| self.botframe = None | ||
| if not self._pytest_postmortem: | ||
| self.stopframe = None | ||
| else: | ||
| self._pytest_postmortem = False | ||
| self.returnframe = None | ||
| self.quitting = False | ||
| self.stoplineno = 0 |
There was a problem hiding this comment.
Would it be possible to call into Bdb.reset for some of this? We're already copy-pasting too much of Bdb's guts into pudb... (If not, add a comment why not.)
There was a problem hiding this comment.
When calling Bdb.reset the debugger stops around there. self.stopframe = None is the offending line. Calling Bdb.reset is a no-go. It is the exact same problem for #67 where also code is copies from Bdb in here. The problem now is that pytest is calling .reset, so that is why the override is needed and to check for the pytest postmortem state. I can add a link to the source of pytest as well, but I believe the docstring of this method explain already enough.
Do you think there needs to be more information in the docstring of this method to explain why it needs to be overriden?
|
@inducer Added more comments. |
This fixes #607. Making the Debugger a singleton should be enough to fix #607. HOWEVER, pytest def postmortem() calls .reset() which resets the stopframe. Somehow, this causes the debugger to stop somewhere inside internal debugger source code, instead of in the code the postmortem should be done.
So, this also includes an override of the .reset() method and detects when the debugger is already running and does not reset the stopframe. See also #67.