-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LazilyUnpickling{Dict,List}: add __repr__ #817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
force-pushed
the
repr-lazilydictlist
branch
from
November 20, 2023 17:16
fbc498a
to
d351025
Compare
matthiasdiener
changed the title
LazilyUnpickling{Dict,List}: better repr
LazilyUnpickling{Dict,List}: add __repr__
Dec 1, 2023
matthiasdiener
force-pushed
the
repr-lazilydictlist
branch
from
December 1, 2023 19:02
d351025
to
059dba1
Compare
This is ready for review. |
inducer
reviewed
Dec 8, 2023
loopy/tools.py
Outdated
@@ -411,6 +411,9 @@ def unpickle(self): | |||
def __getstate__(self): | |||
return {"objstring": self.objstring} | |||
|
|||
def __repr__(self) -> str: | |||
return repr(self.unpickle()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hides the _PickledObject
layer... is that wise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matthiasdiener
force-pushed
the
repr-lazilydictlist
branch
from
February 9, 2024 21:46
8c13355
to
55e1dab
Compare
matthiasdiener
force-pushed
the
repr-lazilydictlist
branch
from
February 12, 2024 20:58
55e1dab
to
ac81ec7
Compare
matthiasdiener
force-pushed
the
repr-lazilydictlist
branch
from
October 8, 2024 14:57
ac81ec7
to
9be8be2
Compare
inducer
force-pushed
the
repr-lazilydictlist
branch
from
November 14, 2024 15:26
9be8be2
to
9ff0285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
(If you want, I could add
__str__
methods that don't include the class names.)