(draft PR for comparison only) Compare old loop nest constraint branch to new branch #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w test: test_find_loop_insn_dep_map_using_cartoon_dep_graph()
…ions during linearization
…ns during linearization
… function, which returns linearization items along with the preprocessed kernel and linearized kernel
…function (created in ancestor branch)
…function (created in ancestor branch)
…used, check kernel option use_dependencies_v2 to determine whether to use the new simplified (cartoon) dep graph instead of insn.depends_on
…constraints from old branch (https://gitlab.tiker.net/jdsteve2/loopy/iname-sets-in-loop-priorities): UnexpandedInameSet, LoopNestConstraints, process_loop_nest_specification, constrain_loop_nesting, update_must_nest_graph, _expand_iname_sets_in_tuple, check_must_not_nest, check_must_not_nest_against_must_nest_graph
…om previous branch (https://gitlab.tiker.net/jdsteve2/loopy/iname-sets-in-loop-priorities): check_must_nest(), is_loop_nesting_valid(); rename function is_loop_nesting_valid->loop_nest_constraints_satisfied
…nonconc_insn_inames_wanted
…new-dependencies-against-sio
…fter promoting func to top level
…ce; make it inline instead (step 1, temporarily keep old func for sanity check)
…new-dependencies-against-sio
…ce; make it inline instead (step 2, after finishing sanity check)
…new-dependencies-against-sio
…ue to previous map machinery update
…ue to previous map machinery update
…t' into statement-instance-order-and-lex-order-map
…new-dependencies-against-sio
…n't actually do anything to submodule...?)
…-during-transformation
jdsteve2
changed the base branch from
new-loop-nest-constraints
to
handle-new-loop-nest-constraints-during-transformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Comparison of old loop nest constraint branch to new one to aid transplantation of functionality. Unfortunately, this branch also has all the new dependency stuff in it, which will also show up in the comparison.
PR for new loop nest constraint branch here.
Comparison seems to be including changes where the branches actually match, but this diff seems to be working.