Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding theme config #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow overriding theme config #44

wants to merge 2 commits into from

Conversation

blackdaemon
Copy link

Currently if theme is used, it's impossible to override its settings in the setup().
Merging the theme config with user config allows to override specific fields in the theme config.

@blackdaemon
Copy link
Author

I squashed the commits into one

@imsi32
Copy link
Owner

imsi32 commented Feb 23, 2025

There were 2 issues that requested this feature but I considered as it can break users theme and also the way I think to achieve this feature was slow in #41 and #38. However, thanks to you, I find an efficient way to implement this feature. So it will merged.

Thank you.

@imsi32
[FEAT] Overriding Theme
b89f84c 
details: Ability to overriding theme in config added. Also config removed after it gives its value to global variables to free memory.
This was linked to issues Feb 23, 2025
Theme config behavior #38
Closed
custom separators dont work!? #41
Closed
@imsi32 imsi32 added the enhancement New feature or request label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom separators dont work!? Theme config behavior
2 participants
@blackdaemon @imsi32