[ci] fix RiskyTruthyFalsyComparison

imdhemy · Apr 2, 2024 · 4d2b108 · 4d2b108
1 parent 8959959
commit 4d2b108
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/ServiceProviders/LiapServiceProvider.php b/src/ServiceProviders/LiapServiceProvider.php
@@ -116,7 +116,7 @@ private function registerConfig(): void
 
         // Check if it should set GOOGLE_APPLICATION_CREDENTIALS to the configured path
         $currentGoogleCredPath = getenv('GOOGLE_APPLICATION_CREDENTIALS');
-        if ($currentGoogleCredPath && file_exists($currentGoogleCredPath)) {
+        if (is_string($currentGoogleCredPath) && file_exists($currentGoogleCredPath)) {
             return;
         }
 

diff --git a/src/Services/AppStoreTestNotificationServiceBuilder.php b/src/Services/AppStoreTestNotificationServiceBuilder.php
@@ -34,10 +34,10 @@ class AppStoreTestNotificationServiceBuilder
      */
     public function build(): AppStoreTestNotificationService
     {
-        assert(! empty($this->issuerId));
-        assert(! empty($this->bundleId));
-        assert(! empty($this->privateKeyId));
-        assert(! empty($this->privateKey));
+        assert(is_string($this->issuerId) && ! empty($this->issuerId));
+        assert(is_string($this->bundleId) && ! empty($this->bundleId));
+        assert(is_string($this->privateKeyId) && ! empty($this->privateKeyId));
+        assert(is_string($this->privateKey) && ! empty($this->privateKey));
 
         $config = GeneratorConfig::forAppStore(
             new Issuer(