go.d fix dimension id check (netdata#18272)

ilyam8 · Aug 7, 2024 · c432b4e · c432b4e
1 parent 25ca3cd
commit c432b4e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/go/plugin/go.d/agent/module/charts.go b/src/go/plugin/go.d/agent/module/charts.go
@@ -439,7 +439,7 @@ func checkDim(d *Dim) error {
 	if d.ID == "" {
 		return errors.New("empty dim ID")
 	}
-	if id := checkID(d.ID); id != -1 {
+	if id := checkID(d.ID); id != -1 && (d.Name == "" || checkID(d.Name) != -1) {
 		return fmt.Errorf("unacceptable symbol in dim ID '%s' : '%c'", d.ID, id)
 	}
 	return nil

diff --git a/src/go/plugin/go.d/agent/module/charts_test.go b/src/go/plugin/go.d/agent/module/charts_test.go
@@ -341,6 +341,9 @@ func TestDim_check(t *testing.T) {
 	dim = &Dim{ID: "id"}
 	dim.ID = "invalid id"
 	assert.Error(t, checkDim(dim))
+
+	dim = &Dim{ID: "i d", Name: "id"}
+	assert.NoError(t, checkDim(dim))
 }
 
 func TestVar_check(t *testing.T) {