Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mpi4py build on AMD #182

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix mpi4py build on AMD #182

merged 1 commit into from
Feb 18, 2025

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Feb 18, 2025 •
edited
Loading

via @MTCam

@matthiasdiener matthiasdiener self-assigned this Feb 18, 2025
@matthiasdiener matthiasdiener marked this pull request as ready for review February 18, 2025 17:45
@matthiasdiener matthiasdiener requested a review from MTCam February 18, 2025 17:45
@matthiasdiener matthiasdiener enabled auto-merge (squash) February 18, 2025 17:45
@matthiasdiener matthiasdiener merged commit f6f4f4b into main Feb 18, 2025
5 checks passed
@matthiasdiener matthiasdiener deleted the matthiasdiener-patch-2 branch February 18, 2025 18:16
inducer
inducer reviewed Feb 18, 2025
View reviewed changes
install-pip-dependencies.sh
@@ -41,7 +41,7 @@ fi
# Install the packages from the requirements file
export MPI4PY_BUILD_CONFIGURE=1

if [[ $(hostname) == tioga* ]]; then
if [[ $(hostname) == tioga* || $(hostname) == odyssey || $(hostname) == tuolumne* ]]; then
# Need extra flags for the mpi4py build
LDFLAGS="$LDFLAGS -Wl,-rpath $CRAYLIBS_X86_64" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being nosy here: Is it really the case that without this flag, MPI silently produces wrong results? (That's the sense I got from the meeting this morning.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your question! No, this fixes startup errors like ImportError: libmodules.so.1: cannot open shared object file: No such file or directory. It is not related to the wrong results we discussed in the morning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer inducer left review comments

@MTCam MTCam Awaiting requested review from MTCam

Assignees

@matthiasdiener matthiasdiener

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiasdiener @inducer @MTCam