Feature/finite difference #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainBertrand
requested review from
calvertdw,
btshrewsbury,
rjgriffin42 and
james-p-foster
SylvainBertrand
commented
Jan 19, 2024
| @@ -1403,4 +1421,351 @@ public static int previous(int index, int listSize) | |||
| { | |||
| return wrap(index - 1, listSize); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
👇 new methods for doing finite difference 👇
SylvainBertrand
commented
Jan 19, 2024
| finiteDifference(previousTransform.getTranslation(), currentTransform.getTranslation(), dt, linearVelocityToPack); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
👇 new methods for integrating 👇
SylvainBertrand
commented
Jan 19, 2024
| double angle = nextDouble(random, minMaxAngle); | ||
| double radius = EuclidCoreTools.squareRoot(1.0 - height * height); | ||
| axisAngleToRandomize.set(radius * EuclidCoreTools.cos(angle), radius * EuclidCoreTools.sin(angle), height, angle); | ||
| axisAngleToRandomize.set(EuclidCoreRandomTools.nextVector3D(random), angle); |
There was a problem hiding this comment.
The old implementation was incorrect in the sense that it wouldn't generate random axes that would be uniformly distributed.
Fixing this seems to break other tests. I'll work on fixing them
calvertdw
approved these changes
Jan 19, 2024
SylvainBertrand
force-pushed
the
feature/finite-difference
branch
from
40f4587 to
5737f56
Compare
james-p-foster
approved these changes
Jan 22, 2024
rjgriffin42
pushed a commit
that referenced
this pull request
Oct 23, 2024
…rame to develop * commit '8ba34f5e5891a2462bfd6974f6f141a137ff19e6': Suppressed a line Updated the doc Completed FixedFrameTuple2DBasics, FixedFrameTuple4DBasics and test Complete FramePoint3DTest and FrameVector3DTest Addition of FixedFramePoint3DBasics.setMatchingFrame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple 1st order finite difference and integration for the different primitives in euclid.
The new stuff is available from
EuclidCoreTools.(I'm thinking about slowly migrating all the tools there so we can reduce the number of tool classes.)
Lemme know whatcha think.