-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text rendering for the level up dialog #9479
Conversation
Hi, @ihhub ! The second one is shifted 1px to the left, while the first one is perfectly centered. I suppose it is not related to the PR. Do you want me to open a separate issue for aligning texts on skills in hero/info windows? |
Hi @Branikolog , I've addressed your comment. Please take a look again. |
Quality Gate passedIssues Measures |
Hi, @ihhub |
@ihhub hi! The initial issue related to lvlup dialog only. |
Hi, @Mr-Bajs !
There are two separate buttons and each of the button corresponds each skill: I think it's better to mention only 1 skill for each corresponding button. |
Hi @Branikolog , let's focus here on what was the original issue. Hi @Mr-Bajs , I would like to keep the changes minimal as the proposed change is not related to the original problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
I'll open an issue for the hero window later then.
close #9459
Additionally, right click popup messages for LEARN buttons were added.