do not expose middleware proxy config

igrek8 · Oct 17, 2022 · 2438736 · 2438736
1 parent 6f96210
commit 2438736
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/metric-reporter.module.test.ts b/src/metric-reporter.module.test.ts
@@ -22,7 +22,8 @@ describe('MetricReporterModule', () => {
         MetricReporterModule.register({
           reporter: new MetricReporter('apiKey'),
           collector: { collect: (_req, _res, metric) => ({ ...metric, _id: '1' }) },
-          configure: (middleware) => middleware.forRoutes('*'),
+          routes: ['*'],
+          excludedRoutes: ['/health'],
         }),
       ],
     }).compile();

diff --git a/src/metric-reporter.module.ts b/src/metric-reporter.module.ts
@@ -17,6 +17,8 @@ export class MetricReporterModule extends ConfigurableModuleClass implements OnM
   }
 
   configure(consumer: MiddlewareConsumer) {
-    this.options.configure(consumer.apply(MetricReporterMiddleware));
+    const config = consumer.apply(MetricReporterMiddleware);
+    if (this.options.excludedRoutes) config.exclude(...this.options.excludedRoutes);
+    config.forRoutes(...this.options.routes);
   }
 }
diff --git a/src/metrics-reporter.module-options.ts b/src/metrics-reporter.module-options.ts
@@ -1,9 +1,10 @@
-import { MiddlewareConfigProxy, MiddlewareConsumer } from '@nestjs/common/interfaces';
+import { RouteInfo } from '@nestjs/common/interfaces';
 import { IMetricReporter } from 'readme-metric-reporter';
 import { IMetricCollector } from 'readme-metric-reporter-express';
 
 export interface MetricReporterModuleOptions {
   reporter: IMetricReporter;
   collector: IMetricCollector;
-  configure(config: MiddlewareConfigProxy): MiddlewareConsumer;
+  routes: (string | RouteInfo)[];
+  excludedRoutes?: (string | RouteInfo)[];
 }