Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow disabling the terminal adapters for selected adapters #10

Merged
merged 13 commits into from
Feb 9, 2025

Conversation

igorlfs
Copy link
Owner

@igorlfs igorlfs commented Jan 26, 2025

This technically breaks how windows are spawned, so I guess it could affect some users

@igorlfs igorlfs marked this pull request as draft January 26, 2025 15:28
@igorlfs igorlfs closed this Jan 26, 2025
@igorlfs igorlfs force-pushed the feat/disable-term-for-adapters branch from 4f4f6c0 to 73e2ecf Compare January 26, 2025 15:47
@igorlfs igorlfs reopened this Jan 26, 2025
@igorlfs igorlfs force-pushed the feat/disable-term-for-adapters branch from da3f015 to a900292 Compare January 26, 2025 20:27
@catgoose
Copy link
Contributor

Did you see the discussion I posted about configuring this in the dap adapter config?

#11

igorlfs and others added 8 commits January 30, 2025 00:14
…t have exceptionBreakpointFilters

Updated the view to explain why there are no exception breakpoints listed

Currently two reasons:
* The dap adapter doesn't support them
* There is no active debug session

Using or between views.cleanup_view() statements

Only show the dap message in Exceptions-view, use dap.session() instead of state

Removed the state annotation for current_session
…examples

ref(terminal): set buftype to nofile

doc: removes terminal close autocommand
@igorlfs igorlfs force-pushed the feat/disable-term-for-adapters branch from db5b39c to e3841b5 Compare January 30, 2025 03:16
@igorlfs igorlfs mentioned this pull request Feb 8, 2025
3 tasks
@poulter7
Copy link

poulter7 commented Feb 8, 2025

Would this change facilitate keeping the terminal hidden when launching the dap (maybe for debugging a test method via neotest and reducing visual jank), but the full dap-view UI (terminal and repl/watches etc.) to appear with a keymap?

@igorlfs igorlfs mentioned this pull request Feb 8, 2025
@igorlfs
Copy link
Owner Author

igorlfs commented Feb 9, 2025

Would this change facilitate keeping the terminal hidden when launching the dap (maybe for debugging a test method via neotest and reducing visual jank), but the full dap-view UI (terminal and repl/watches etc.) to appear with a keymap?

The goal is to have the terminal always hidden, since it's useless for some adapters. But we could have a start_hidden setting to achieve the behavior you're describing. Can you open an issue, so it can more easily tracked?

@igorlfs igorlfs force-pushed the feat/disable-term-for-adapters branch from c4b683a to 6ce6213 Compare February 9, 2025 22:47
@igorlfs igorlfs marked this pull request as ready for review February 9, 2025 23:00
@igorlfs igorlfs changed the title feat: allow disabling the terminal adapters for selected adapters feat!: allow disabling the terminal adapters for selected adapters Feb 9, 2025
@igorlfs igorlfs merged commit 80381ef into main Feb 9, 2025
2 checks passed
@igorlfs igorlfs deleted the feat/disable-term-for-adapters branch February 9, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants