Merge pull request #529 from igorkamyshev/fix-safari-14-0-issue-with-url

igorkamyshev · Jan 30, 2025 · 1f54e10 · 1f54e10
2 parents f13a916 + 5a28d32
commit 1f54e10
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/heavy-otters-hang.md b/.changeset/heavy-otters-hang.md
@@ -0,0 +1,5 @@
+---
+"@farfetched/core": patch
+---
+
+Add workaround for Safari 14.0 bugged implementation of URL constructor
diff --git a/packages/core/src/fetch/lib.ts b/packages/core/src/fetch/lib.ts
@@ -93,8 +93,14 @@ export function formatUrl(
     urlString = `${url}?${queryString}`;
   }
 
+  /**
+   * Workararound for Safari 14.0
+   * @see https://github.com/igorkamyshev/farfetched/issues/528
+   */
+  const urlArgs = [urlString, urlBase].filter(Boolean) as [string, string];
+
   try {
-    return new URL(urlString, urlBase);
+    return new URL(...urlArgs);
   } catch (e) {
     throw configurationError({
       reason: 'Invalid URL',