Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ia): fix AlarmQueryResult method names #307

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

cesarcoatl
Copy link
Member

@cesarcoatl cesarcoatl commented Nov 6, 2024

there were typos in two methods:

  • getAssociatedDate → getAssociatedData
  • getDataSet → getDataset

fix: #306

Summary by Sourcery

Bug Fixes:

  • Correct method names in the AlarmQueryResult class by renaming getAssociatedDate to getAssociatedData and getDataSet to getDataset.

there were typos in two methods:
- getAssociatedDate → getAssociatedData
- getDataSet → getDataset

fix: #306
Copy link
Contributor

sourcery-ai bot commented Nov 6, 2024

Reviewer's Guide by Sourcery

This PR fixes typos in two method names within the AlarmQueryResult class. The changes ensure consistent naming conventions by correcting 'getAssociatedDate' to 'getAssociatedData' and 'getDataSet' to 'getDataset'.

Updated class diagram for AlarmQueryResult

classDiagram
    class AlarmQueryResult {
        +Dataset getAssociatedData(AnyStr uuid)
        +Dataset getDataset()
    }
    note for AlarmQueryResult "Method names corrected from getAssociatedDate to getAssociatedData and from getDataSet to getDataset"
Loading

File-Level Changes

Change Details Files
Fixed method name typos in the AlarmQueryResult interface
  • Renamed 'getAssociatedDate' to 'getAssociatedData' to correctly reflect its purpose of retrieving associated data
  • Renamed 'getDataSet' to 'getDataset' to follow consistent camelCase naming convention
src/com/inductiveautomation/ignition/common/alarming/query/__init__.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cesarcoatl - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cesarcoatl cesarcoatl merged commit 4f8ce47 into main Nov 6, 2024
3 checks passed
@cesarcoatl cesarcoatl deleted the fix/ia/AlarmQueryResult-typos branch November 6, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Code completion Casing issues in class AlarmQueryResultImpl (getDataSet)
1 participant