OF-2559: Do not assume that all connections have established TLS #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sensible checks, no reason this can't go in |
AlexGidman
approved these changes
Aug 4, 2023
This intends to guard against null pointer exceptions.
guusdk
force-pushed
the
OF-2559_Session-NPE
branch
from
d3c1f22
to
8f5e8cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to guard against null pointer exceptions.
With the new Netty code, I'm seeing null pointer exceptions on the admin console (see screenshot).
Although this PR might prevent the NPE, there migth be a deeper issue that is not addressed by this PR. At the time that this screenshot was taken, Openfire did not have any active server-to-server sessions (as verified by the
netstatcommand).