Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OF-2627: Correctly URL-escape group names in admin console #2218

Merged
merged 2 commits into from
Jul 21, 2023
Merged

OF-2627: Correctly URL-escape group names in admin console #2218

merged 2 commits into from
Jul 21, 2023

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Jul 17, 2023

This prevents issues with working with group names that have URL-escaped characters in their name (like the + character).

@guusdk
OF-2627: Correctly URL-escape group names in admin console
53adb8a 
This prevents issues with working with group names that have URL-escaped characters in their name (like the `+` character).
@guusdk guusdk requested a review from Fishbowler July 17, 2023 12:36
@Fishbowler Fishbowler self-assigned this Jul 20, 2023
Fishbowler
Fishbowler approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Fishbowler Fishbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with group names:

test+test
test/test
test test
test"test
test()test
test@test
test😳test

@Fishbowler Fishbowler removed their assignment Jul 21, 2023
@Fishbowler Fishbowler merged commit 162a33d into igniterealtime:main Jul 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishbowler Fishbowler Fishbowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guusdk @Fishbowler