Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should generate javadoc #2215

Merged
merged 7 commits into from
Jul 14, 2023

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Jul 14, 2023

Adding the 'ci' Maven profile to be used by the continuous integration build / Github flow.

This intends to generate javadoc (and maybe source) artifacts that are uploaded to the Maven repo.

Adding the 'ci' Maven profile to be used by the continuous integration build / Github flow.

This intends to generate javadoc (and maybe source) artifacts that are uploaded to the Maven repo.
@guusdk guusdk requested a review from akrherz July 14, 2023 13:43
This prevents successful compilation on other versions of Java.
For a reason beyond me, the CI-profile of Maven causes the unit tests to fail (with instrumentation errors) when running on Java 17.

This removes the CI profile from the generic build phase.

The CI profile (and thus, generation of Javadoc and Sources) is still active on the 'deploy' phase. In this phase, only Java 11 is used.
@akrherz akrherz merged commit 1e8332a into igniterealtime:main Jul 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants