OF-1112: Switch to MINA for inbound S2S #2159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a provisional change that switches inbound s2s traffic from the old net-io implementation to the newer nio (based on MINA).
In my limited tests, this seemed to work while setting up s2s connections, both with Dialback as with SASL External.
More work is probably desired. I particularly want to identify all code that can now be removed (as it's replaced by this change), while unmarking code as being 'deprecated' that is not (some classes that have already been marked as being deprecated in anticipation of this change remain in use, for example to initiate outbound traffic).
It is probably best to not remove the old implementation until after the new implementation has been released, and has proven itself. I'd like to give users an opportunity to reconfigure Openfire to use the old implementation. A similar configuration option existed when moving from the old IO to NIO for client-to-server traffic.
MINA's 2.2 branch seems to have a change in its TLS handling that almost guarantees a deadlock when working with Stream Management. This isn't related to the change in this PR, but might be reason to move away from MINA.