Skip to content

Commit

Permalink
OF-2611: S2S Unit test: clean up TODOs, add spec references
Browse files Browse the repository at this point in the history 
This adds references to RFCs in the ExpectedOutcome calculation, and removes some of the TODO statements in that class.

Most of the TODOs are 'resolved' by adding a 'strictCertificateValidation' setting in the calculation. This is used to choose between the multiple possible outcomes that were in the 'TODO'.

Note taht the strictCertificateValidation setting is hardcoded in all tests. The current implementation makes it hard to configure different values for the initiating and receiving entities. Also, they would add to an already long list of tests.
  • Loading branch information
@guusdk
guusdk committed Jul 20, 2023
1 parent fce3846 commit 060b522
Show file tree
Hide file tree
Showing 4 changed files with 70 additions and 48 deletions.
Loading

0 comments on commit 060b522

Please sign in to comment.