Squeeze multiple slashes in URLs #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.5 has removed the normalization of multiple slashes in URLs, so
you can get 301 redirect errors if you run for example
`Model.get('/batch/id')`.
```
2.4 > URI.parse("http://example.org").merge('people//batch///id')
=> #<URI::HTTP http://example.org/people/batch/id>
^ ^
```
```
2.5 > URI.parse("http://example.org").merge('people//batch///id')
=> #<URI::HTTP http://example.org/people//batch///id>
^^ ^^^
```
In Hawk's use case, it should be safe to assume that paths should be
squeezed, but since this can be considered a breaking change, this
commit also bumps the major version number
Ref: https://bugs.ruby-lang.org/issues/8352
tagliala
force-pushed
the
bugfix/squeeze-double-slashes
branch
from
ad8507e to
bd07aa2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.5 has removed the normalization of multiple slashes in URLs, so you can get 301 redirect errors if you run for example
Model.get('/batch/id').In Hawk's use case, it should be safe to assume that paths should be squeezed, but since this can be considered a breaking change, this commit also bumps the major version number
Ref: https://bugs.ruby-lang.org/issues/8352