Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash/Error should be reported #9

Closed
jeremi opened this issue Dec 8, 2021 · 8 comments
Closed

Crash/Error should be reported #9

jeremi opened this issue Dec 8, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jeremi
Copy link

jeremi commented Dec 8, 2021

Add support for reporting logs/errors in Google Firebase / Sentry.

By default we should not provide the config, we will inject it only in builds we do.

@kneckinator kneckinator changed the title Crash/Error should be reported. Crash/Error should be reported Jan 5, 2022
@kneckinator
Copy link
Collaborator

Firebase Crashlytics supports iOS and Android: https://firebase.google.com/docs/crashlytics
Sentry supports "everything and beyond" and has Reactive Native dependency that can be used. See: https://sentry.io/for/mobile/?platform=sentry.javascript.react-native

@rjmangubat23 rjmangubat23 self-assigned this Jan 24, 2022
@kneckinator kneckinator transferred this issue from another repository Feb 15, 2022
@kneckinator kneckinator added this to the 0.2.1 milestone Feb 15, 2022
@jeremi
Copy link
Author

jeremi commented Feb 16, 2022

@rjmangubat23 can you update with your status?

@rjmangubat23
Copy link
Collaborator

@jeremi still in progress with this, I have already locally setup Sentry on my end the only thing remaining is adding config for setting flag via app.config.js.

@kneckinator kneckinator added the enhancement New feature or request label Feb 16, 2022
@kneckinator
Copy link
Collaborator

@rjmangubat23 Has there been any progress on this?

@rjmangubat23
Copy link
Collaborator

@kneckinator I have only transferred initial work to my local branch via inji repo but apart from that sorry no updates yet.

@kneckinator
Copy link
Collaborator

Now that we have implemented #77 can we close this?

@rjmangubat23
Copy link
Collaborator

rjmangubat23 commented Mar 7, 2022

yes I agree @kneckinator, If they need something more advanced we can then add Sentry. @jeremi what do you think?

@jeremi
Copy link
Author

jeremi commented Mar 7, 2022

Yes, I'm good with it.

@jeremi jeremi closed this as completed Mar 7, 2022
pmigueld pushed a commit that referenced this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants