Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request VC via ODK Intent #183

Open
9 tasks done
rjmangubat23 opened this issue May 10, 2022 · 3 comments · Fixed by #199
Open
9 tasks done

Request VC via ODK Intent #183

rjmangubat23 opened this issue May 10, 2022 · 3 comments · Fixed by #199
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rjmangubat23
Copy link
Collaborator

rjmangubat23 commented May 10, 2022

Is your feature request related to a problem? Please describe.
ODK Intent implementation when requesting for a VC

Describe the solution you'd like

  • Setup and add XLSForm in https://odk.newlogic-demo.com/
  • Add Initial VC key pair fields
  • Add Intent in Manifest
  • launch Mosip app via ODK Collect
  • Route to Request screen for VC sharing
    • Find a way to detect if we launched as an intent
  • Send VC via bundle
    • Pass data from React Native to Android code

TODOs:

  • Update integration to work with latest version of Inji
@rjmangubat23 rjmangubat23 added enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet labels May 10, 2022
@rjmangubat23
Copy link
Collaborator Author

@jeremi we would like to request to please add appropriate milestone version. Thanks!

@jeremi jeremi added this to the 0.4.0 milestone May 11, 2022
@rjmangubat23 rjmangubat23 removed the triage This issue is pending confirmation and planning and should not be worked on yet label May 17, 2022
@pmigueld
Copy link
Collaborator

Short demo of ODK intent:

https://www.loom.com/share/262fc1c1f76a4fc0ba48023c1e5d1d5f

Submitted data here:

https://odk.newlogic-demo.com/#/projects/1/forms/mosip_inji_ona_registration_example/submissions

Some open questions:

  • Are there best practices that should be followed when sharing VC data through an intent like how can we make it secure and restricted to the Inji app?
  • How do we design a consent flow where the user is made aware that another application will be receiving their VC data?
  • Currently the app opens as usual with the only change added to re-route to the Request screen when launched as intent (io.mosip.residentapp.odk.REQUEST), should they be restricted to the Request screen with other parts of the UI hidden like the bottom bar?

@pmigueld
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
3 participants