Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 20 Actions #21

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Update to Node 20 Actions #21

merged 1 commit into from
Jan 31, 2024

Conversation

ReeceHumphreys
Copy link
Contributor

Is there anything special we need to do for this repo @pepone? I know subtree this repo into icerpc-csharp and vscode-slice. When I went to just commit directly to the main branch it warned me that I would be ignoring some repo rules if I did that.

@InsertCreativityHere
Copy link
Member

To my understanding, it's always fine to update icerpc-slice, you just need to be careful handling the subtrees.
Namely that they should be updated, and any changes should be done using subtree-pulls.

@pepone
Copy link
Member

pepone commented Jan 31, 2024

As @InsertCreativityHere wrote it is fine to update this repo directly. I wouldn't bother updating the subtrees in other repos until there is relevant changes.

@ReeceHumphreys ReeceHumphreys merged commit a382541 into main Jan 31, 2024
2 checks passed
@ReeceHumphreys ReeceHumphreys deleted the node-20-actions branch January 31, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants