Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flow control based on a dynamic window size #3304

Open
bentoi opened this issue Jun 6, 2023 · 1 comment
Open

Investigate flow control based on a dynamic window size #3304

bentoi opened this issue Jun 6, 2023 · 1 comment
Labels
enhancement slic Slic Transport
Milestone
Future

Comments

@bentoi
Copy link
Contributor

bentoi commented Jun 6, 2023 

          I wonder if control flow is the limiting factor here, see https://github.com/dotnet/runtime/issues/53372 and the linked issue https://github.com/dotnet/runtime/issues/43086

Seems similar to what we experience with ice(tcp) vs icerpc(slic)

If you capture the gRPC traffic for our comparative benchmarks, you will see the Widow size is dynamically increased.

Originally posted by @pepone in #3266 (comment)
@bentoi bentoi added this to the 0.2 milestone Jun 6, 2023
@pepone pepone mentioned this issue Jun 6, 2023
Merged
@bentoi bentoi mentioned this issue Jun 7, 2023
Closed
@bentoi
Copy link
Contributor Author

bentoi commented Jun 7, 2023 •
edited
Loading

See also #3316

@bentoi bentoi mentioned this issue Jun 7, 2023
Closed
@bernardnormier bernardnormier added the slic Slic Transport label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement slic Slic Transport
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@bentoi @bernardnormier