Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rush with pnpm + lage + beachball #707

Merged
merged 36 commits into from
Jan 5, 2024
Merged

Replace rush with pnpm + lage + beachball #707

merged 36 commits into from
Jan 5, 2024

Conversation

saskliutas
Copy link
Member

Replaced rush with pnpm + lage + beachball. This allows to better control different workflows of the monorepo: dependencies managing, building/testing packages and versioning.

Developer workflows should be similar to the ones before only need to replace rush with pnpm run when executing commands eg. rush build -> pnpm run build, rush cover -> pnpm run cover, etc.

Added setup for prettier. It is not enforced at the moment but it could be run in CI pipeline to make keep code format consistent.

@saskliutas saskliutas requested a review from aruniverse December 8, 2023 15:00
beachball.config.js Dismissed Show dismissed Hide dismissed
beachball.config.js Dismissed Show dismissed Hide dismissed
@saskliutas
Copy link
Member Author

@aruniverse I guess we will need to create new pipelines or can we make the old ones point to the new definition files?

@aruniverse
Copy link
Member

@aruniverse I guess we will need to create new pipelines or can we make the old ones point to the new definition files?

we will need new pipelines, cant replace the existing ones with updated definitions

@saskliutas saskliutas requested a review from grigasp December 12, 2023 14:50
.pnpmfile.cjs Outdated Show resolved Hide resolved
.pnpmfile.cjs Outdated Show resolved Hide resolved
beachball.config.js Outdated Show resolved Hide resolved
beachball.config.js Outdated Show resolved Hide resolved
.pnpmfile.cjs Outdated Show resolved Hide resolved
.pipelines/pr.yaml Outdated Show resolved Hide resolved
.pipelines/templates/build-steps.yaml Outdated Show resolved Hide resolved
@saskliutas saskliutas merged commit 5d64b08 into master Jan 5, 2024
8 checks passed
@saskliutas saskliutas deleted the remove_rush branch January 5, 2024 12:46
@mdastous-bentley
Copy link
Contributor

@saskliutas @aruniverse How do I build, update now ? I have little experience with pnpm.

@aruniverse
Copy link
Member

@saskliutas @aruniverse How do I build, update now ? I have little experience with pnpm.

its in the description

image
take a look at the docs, https://pnpm.io/cli/run

@mdastous-bentley
Copy link
Contributor

@saskliutas @aruniverse How do I build, update now ? I have little experience with pnpm.

its in the description

image take a look at the docs, https://pnpm.io/cli/run

After updating, pnpm is not available, should I global install pnpm ? Which version ?

@saskliutas
Copy link
Member Author

@saskliutas @aruniverse How do I build, update now ? I have little experience with pnpm.

its in the description
image take a look at the docs, https://pnpm.io/cli/run

After updating, pnpm is not available, should I global install pnpm ? Which version ?

Yes you need to install it globally. You can use latest version. Only requirement is that it would be >8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants