Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a possibility to re-add deleted elements with preserved ids #209

Merged
merged 33 commits into from
Oct 10, 2024
Merged

Add a possibility to re-add deleted elements with preserved ids #209

merged 33 commits into from
Oct 10, 2024

Conversation

derbynn
Copy link
Contributor

@derbynn derbynn commented Sep 26, 2024 •
edited
Loading

  • Perform early checks during exportElement to take advantage of this.context.findTargetElementId i.e. look for cases where element exists but has different id in target or element id in target is not available, as some other element uses that id and throw an error for those cases.
  • Otherwise, update if we find the element in target db or insert if element is not in target db yet

@derbynn derbynn marked this pull request as ready for review September 27, 2024 15:09
@derbynn derbynn requested review from a team as code owners September 27, 2024 15:09
@derbynn derbynn linked an issue Sep 27, 2024 that may be closed by this pull request
Add a posibility to re-add deleted elements with preserved ids #200
Closed
nick4598
nick4598 reviewed Sep 30, 2024
View reviewed changes
nick4598
nick4598 reviewed Oct 1, 2024
View reviewed changes
nick4598
nick4598 reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@nick4598 nick4598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if all 4 cases described in the work item are covered by our tests?

derbynn and others added 4 commits October 3, 2024 09:29
@derbynn @nick4598
Improve elementToUpdate set comments
030db68 
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
@derbynn @nick4598
Improve elementToUpdate set comments
41ac9a5 
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
@derbynn @nick4598
Improve fromTransformation option description
d284496 
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
@derbynn @nick4598
Update elementsToUpdate set description
1bb52a8 
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
nick4598
nick4598 previously approved these changes Oct 4, 2024
View reviewed changes
nick4598
nick4598 previously approved these changes Oct 4, 2024
View reviewed changes
nick4598
nick4598 reviewed Oct 8, 2024
View reviewed changes
derbynn and others added 3 commits October 8, 2024 16:08
@derbynn derbynn merged commit 3bcd850 into main Oct 10, 2024
16 checks passed
@derbynn derbynn deleted the daniel/preserved-ids-for-filtering branch October 10, 2024 15:47
nick4598 added a commit that referenced this pull request Nov 20, 2024
@derbynn @nick4598
Add a possibility to re-add deleted elements with preserved ids (#209)
018e233 
- add more cases to support preserveElementIdsForFiltering options
---------

Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick4598 nick4598 nick4598 approved these changes

@JulijaRamoskiene JulijaRamoskiene JulijaRamoskiene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a posibility to re-add deleted elements with preserved ids
3 participants
@derbynn @nick4598 @JulijaRamoskiene