Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When releasing a version of imodel-transformer that depends on itwinjs 5.0 #227

Open
nick4598 opened this issue Jan 6, 2025 · 3 comments

Comments

@nick4598
Copy link
Collaborator

nick4598 commented Jan 6, 2025

Some changes to react to from core: iTwin/itwinjs-core#7512

Be sure to update dependency on @itwin/imodel-transformer in example-code/snippets of itwinjs-core https://github.com/iTwin/itwinjs-core/blob/6ced42f17813389b970aa962903dd826131350e9/example-code/snippets/package.json#L33

@pmconne
Copy link
Member

pmconne commented Jan 6, 2025

#225

It's kinda unfortunate to have tests and example code in itwinjs-core repo that depend on imodel-transformer package.

@nick4598
Copy link
Collaborator Author

nick4598 commented Jan 6, 2025

agree, talking to ben about what we can do wrt to example code snippets / learning section in docs from transformer repo only

@nick4598
Copy link
Collaborator Author

nick4598 commented Jan 7, 2025

https://github.com/iTwin/imodel-transformer/pull/228/files initial PR to move the code snippets over to this repo.

Might stay open for a bit as we still need to look at the 'learning' section and how that works when adding to it from transformer repo. (So that we can safely remove from the learning/transformer section in the core repo, which is the one that originally referenced these code snippets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants