Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log level to handle crash #44

Merged
merged 2 commits into from
May 22, 2017
Merged

Add log level to handle crash #44

merged 2 commits into from
May 22, 2017

Conversation

iGitScor
Copy link
Owner

Pull request

Proposal

What kind of change does this PR introduce?

Add log level to handle crash

Did you add tests for your changes?

Yes

Summary

If the file is not found, allow to alert the developer and not crash the webpack build

Other information

Issue #24

GIF

crash

@codecov
Copy link

codecov bot commented Apr 28, 2017

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #44   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      5    +2     
  Lines          51     93   +42     
  Branches       16     25    +9     
=====================================
+ Hits           51     93   +42
Impacted Files Coverage Δ
helpers/logger.js 100% <100%> (ø)
workflow_test/webpack.error.config.js 100% <100%> (ø)
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd93be7...557e83a. Read the comment docs.

@iGitScor iGitScor merged commit 2204574 into master May 22, 2017
@iGitScor iGitScor deleted the feat/log-level branch May 22, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant