Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #12

Open
iGitScor opened this issue Mar 4, 2017 · 2 comments
Open

Update changelog #12

iGitScor opened this issue Mar 4, 2017 · 2 comments

Comments

@iGitScor
Copy link
Owner

iGitScor commented Mar 4, 2017

Hi,

We have to update the changelog.
For that, we need to see changes between 1.2 and 1.2.5

After that, we'll be able to publish the new version to npm and improve the project

Thank you

@kmulligan
Copy link

kmulligan commented Mar 15, 2017

I come from Your First PR on Twitter.

3 things:

  1. Would be glad to keep my first PR to help out with this, but going to need guidance. Do you mean just updating CHANGELOG.md? How would I know what's changed between 1.2 and 1.2.5?

  2. I noticed a typo in the js files in /lib/. Kickstarter is misspelled. Seems like a simple enough fix for a first PR as well?:

 * This file is part of the Kickstarter.
 *
 * **(c) iGitScor <http://github.com/iGitScor/kicksterter>**
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
  1. Maybe add something in the README.md to explain what the kickstarter does? It seems unclear to me at first reading. But that's probably because I'm a newb :)

@iGitScor
Copy link
Owner Author

Hi @kmulligan,

sorry for the response delay
Welcome !

The task is to have a complete changelog, but unfortunately it's not up to date
You can make any improvement you mentioned above

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants