refactor: api types #200
Open
refactor: api types #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapetr
reviewed
Feb 4, 2025
src/layout/providers/AppProvider.tsx
Outdated
| project: Project; | ||
| project: ProjectResponse; |
There was a problem hiding this comment.
I'm not sure this type of refactor is necessary, I personally wouldn't do it - project is entity (it is also found in the list, not just project detail response) in this context, so I'd keep the current naming. I understand the entity = response object in this case, but I'd just do this, if we want to explicitly export the detail response type:
export type Project = ProjectResponse;
But it's open for debate :)
There was a problem hiding this comment.
I totally agree. Will make use of the export type Project = ProjectResponse;.
# Conflicts: # src/app/(main)/[projectId]/apps/builder/t/[threadId]/page.tsx # src/modules/chat/message/RunSetupDelta.tsx # src/modules/chat/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.