Fix boolean filter behavior #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Case: * Have one boolean filter in a grid * Have one other filter in the same grid * Filter the grid using the other filter IS: * The boolean filter jumps to "No" * On the next request, the "No" is applied for this filter SHOULD: * The boolean filter stays empty and doesn't affect the results This PR fixes this behavior. It also makes sure that a boolean filter is applied after the value is changed.
Vinai
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case:
IS:
SHOULD:
This PR fixes this behavior. It also makes sure that a boolean filter is applied after the value is changed.